Skip to content

Fix airlock sensor updating #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NataKilar merged 1 commit into from
Mar 14, 2023
Merged

Fix airlock sensor updating #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion code/game/machinery/doors/airlock_control.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@
var/datum/gas_mixture/air_sample = return_air()
var/new_pressure = round(air_sample.return_pressure(),0.1)

if(abs(pressure - new_pressure) > 0.001 || pressure == null)
//Try preventing the sensor from spamming when there's no differences, and the controller isn't cycling.
//Can't rely only on difference, since it's possible for the pressure to stay nearly the same for a few calls, which prevents the machine var from updating
if(abs(pressure - new_pressure) > 0.001 || master_cycling)
var/decl/public_access/public_variable/airlock_pressure/pressure_var = GET_DECL(/decl/public_access/public_variable/airlock_pressure)
pressure_var.write_var(src, new_pressure)

Expand Down
3 changes: 1 addition & 2 deletions code/game/machinery/embedded_controller/airlock_program.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,7 @@
if(!receive_tag) return

if(receive_tag==tag_chamber_sensor)
if(signal.data["pressure"])
memory["chamber_sensor_pressure"] = text2num(signal.data["pressure"])
memory["chamber_sensor_pressure"] = text2num(signal.data["pressure"])

else if(receive_tag==tag_exterior_sensor)
memory["external_sensor_pressure"] = text2num(signal.data["pressure"])
Expand Down