Trade Beacons, Imports and Exports#438
Merged
PsyCommando merged 50 commits intoPersistentSS13:devfrom Mar 18, 2023
Merged
Conversation
remove comma
Adds trade beacons to persistence, devices scattered across the overmap that give access to unique import/export opportunities. This includes a new network device that lets networks take control of trade beacons. The entire system is in place and functional, but we still need to add imports/exports and a variety of trade beacons. I will save that for future updates.
PsyCommando
added
the
💲 economy
PsyCommando
requested changes
Mar 14, 2023
Collaborator
PsyCommando
left a comment
PsyCommando
left a comment
There was a problem hiding this comment.
Got a bunch of suggestions for you.
I didn't really look too deep into functionality since @NataKilar is way more up to date on network and economy stuff than I am.
code/game/objects/items/weapons/circuitboards/machinery/network.dm
Outdated
Show resolved
Hide resolved
mods/persistence/modules/modular_computers/file_system/programs/trade_beacon_program.dm
Show resolved
Hide resolved
mods/persistence/modules/modular_computers/file_system/programs/trade_beacon_program.dm
Show resolved
Hide resolved
mods/persistence/modules/modular_computers/file_system/programs/trade_beacon_program.dm
Show resolved
Hide resolved
NataKilar
reviewed
Mar 15, 2023
PsyCommando
requested changes
Mar 16, 2023
Collaborator
PsyCommando
left a comment
PsyCommando
left a comment
There was a problem hiding this comment.
Just a few small things, then it'll be ready for merge IMO.
Co-authored-by: PsyCommando <PsyCommando@users.noreply.github.com>
Co-authored-by: PsyCommando <PsyCommando@users.noreply.github.com>
Co-authored-by: PsyCommando <PsyCommando@users.noreply.github.com>
PsyCommando
approved these changes
Mar 18, 2023
Collaborator
PsyCommando
left a comment
PsyCommando
left a comment
There was a problem hiding this comment.
Might need some tidying up, but should be good enough for now.
Collaborator
|
gonna squashmerge because that's a thiccboi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a trade beacon subsystem that places beacons around the overmap that can be interacted with by nearby sectors. The trade beacon inventory refreshes every 2 hours.
Adds an import/export program and telepads that can buy and sell goods from these trade beacons
Adds a new network device that can take control of trade beacons and impose taxes and restrictions.