Conversation
PsyCommando
reviewed
Mar 18, 2023
|
|
||
| /mob/living/limbo/Initialize() | ||
| . = ..() | ||
| var/obj/item/organ/internal/stack/cortical_stack |
Collaborator
There was a problem hiding this comment.
You sure it's a good idea to keep a ref directly like that? Because, if it has a stack it'll be iniside of it, no?
loc references don't prevent deleting, but that var would.
Collaborator
Author
There was a problem hiding this comment.
Sure, the cortical stack should clear this on deletion.
PsyCommando
approved these changes
Mar 18, 2023
Collaborator
PsyCommando
left a comment
PsyCommando
left a comment
There was a problem hiding this comment.
I'm not really seeing any significant problems with this. So it should be good.
| maploader.load_map(file("maps/chargen/chargen.dmm"), ((x - 1) * width) + 1, ((y - 1) * height) + 1, map_z, no_changeturf = TRUE) | ||
| CHECK_TICK | ||
|
|
||
| limbo_holder = new(locate(world.maxx / 2, world.maxy / 2, map_z)) |
Collaborator
There was a problem hiding this comment.
I guess that'll work for now, but that's a bit rough around the edges XD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Why and what will this PR improve
Fixes some bugs that made cloning currently non-functional. Allows for non-tedious admin revives etc,
Fixes #422