Merged
Conversation
PsyCommando
reviewed
Jun 29, 2023
|
|
||
| spawning = TRUE | ||
| var/DBQuery/char_query = dbcon_save.NewQuery("SELECT `key` FROM `limbo` WHERE `type` = '[LIMBO_MIND]' AND `metadata` = '[key]' AND `metadata2` = '[selected_char_name]'") | ||
| var/DBQuery/char_query = dbcon_save.NewQuery("SELECT `key` FROM `limbo` WHERE `type` = '[LIMBO_MIND]' AND `metadata` = '[sanitize_sql(key)]' AND `metadata2` = '[sanitize_sql(selected_char_name)]'") |
Collaborator
There was a problem hiding this comment.
Just a comment, but we really should keep db queries all at the same place. Having all that stuff all over the code is a nightmare for maintenance.
Collaborator
Author
There was a problem hiding this comment.
I agree. I also greatly dislike this whole metadata and metadata2 business so I'd like to solve that simultaneously if we can.
PsyCommando
added
🪲 bug
PsyCommando
approved these changes
Jun 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes being unable to load in with characters with apostrophes/other special characters in their names. This was caused by some missing sanitization in SQL statements and Topic. Also fixes the "Error: you are not an admin" spam created by some missing arguments in checking permissions.
One change should eventually be set upstream: crew records checking against sanitized names in
get_crew_record, since this also breaks with apostrophes etc.Authorship
Myself. Thanks to Unleashed for finding these bugs.