Merged
Conversation
ad0fb8c to
1cae53e
Compare
Collaborator
|
I guess this will do for now. But assigning z-levels will have to be revisited at one point. It's not reliable across saves to refer directly to z-indices instead of zlevel ids. Especially if anything z-level ordering related changes. |
PsyCommando
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adjusts the level ordering code so that mapped levels are offset in case that
world.maxzis greater than the minimum mapped z-index in the database. This solves an issue that was occurring with templates that are spawned pre-load (like the supply shuttle) getting overridden. Also makes it so that levels are always spawned with the correct level data, since the game doesn't like having duplicates of the Kleibkhar level datas, since they have a static ID.