Fixes at least one cause of missing arms on load#467
Merged
PsyCommando merged 1 commit intoPersistentSS13:devfrom Sep 19, 2023
Merged
Fixes at least one cause of missing arms on load#467PsyCommando merged 1 commit intoPersistentSS13:devfrom
PsyCommando merged 1 commit intoPersistentSS13:devfrom
Conversation
PsyCommando
added
🪲 bug
PsyCommando
approved these changes
Sep 19, 2023
Collaborator
PsyCommando
left a comment
PsyCommando
left a comment
There was a problem hiding this comment.
A bit dirty not going to lie, but if it works for now that's good enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds a check to prevent eye organ installation rebuilding human icons too early (during deserialization), causing icon cache corruption and missing icons for human arms and hands on load. Theoretically anything that calls
update_bodytoo early could cause this issue, but from at least my quick testing, this is the lone offender atm.This could go upstream, but I'd like to be sure it solves the problem and we don't need to add additional checks in strange circumstances later.
Authorship
Myself. Thanks to Psy and Nebula for helpful discussions.