Conversation
acd98aa to
d143441
Compare
PsyCommando
left a comment
There was a problem hiding this comment.
Hmm, I'm a bit wary of the wrapper and list code right now since we've had those pid mismatch this summer. I kinda wonder if in the future we couldn't just serialize those simpler types into json text and dump it into a custom saved var instead?
Cause, the wrapper stuff is a tiny bit hacky and hard to debug. And like if we keep adding new wrapper types we'll end up significantly increasing memory usage and processing for something arguably a little more convenient than json?
I'll approve this, since it seems fine. But just some food for thoughts.
I agree in general, unneccesary wrappers should be avoided. I don't recall the exact reason why I used a wrapper here, but I believe it's because it stopped us from having to mess with core Initialization code for the telecomms machine, which is the only place channels are saved. |
Description of changes
Network telecomms now saves properly. Channels are wrapped as lists for rebuilding on load. Radios update their available channels through the receiver/transmit chain, so no additional handling is necessary on round start (outside of some encryption key hackiness).
While working on network access stuff, I went ahead and changed network ID interactions so that
attack_selfopens the login interface on network IDs, which is used far more than flashing the ID (which has been moved to a verb).Authorship
Myself