Decl saving improvements#478
Merged
PsyCommando merged 2 commits intoPersistentSS13:devfrom Dec 7, 2023
Merged
Conversation
PsyCommando
added
the
💾 serialization
NataKilar
dismissed
PsyCommando’s stale review
The merge-base changed after approval.
PsyCommando
previously approved these changes
Dec 7, 2023
NataKilar
dismissed
PsyCommando’s stale review
The merge-base changed after approval.
PsyCommando
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes decl serialization to use a serializer type rather than a wrapper, directly converting the saved path to a decl on de-serialization
Depends on #477.
Why and what will this PR improve
Decls are widespread enough (present on almost everything for materials) that it doesn't make sense to require the creation and flattening of a wrapper object for each one. Moving the logic to be internal to the serializers will improve performance and cleanliness.
Authorship
Myself