Fix 'Zip' + 12g box icons#481
Merged
Milkshak3s merged 1 commit intoPersistentSS13:devfrom Dec 30, 2023
Merged
Conversation
Milkshak3s
approved these changes
Dec 30, 2023
Collaborator
Milkshak3s
left a comment
Milkshak3s
left a comment
There was a problem hiding this comment.
I'm not sure what this does, but I approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes magazines.dmi to have the correct icon names for 12g boxes.
Also, fixes the 'Zip' handgun to show up in-hand as well as having its magazine not disappear (visually) when it's out of ammo
Why and what will this PR improve
Reduces sprite-jank. Also, guns being visible to others in-hand is really important.
Authorship
genessee did this
Changelog
🆑
bugfix: 12-gauge ammunition boxes are no longer invisible
bugfix: The .22LR 'Zip' is now visible when held-in hand
bugfix: The .22LR 'Zip' no longer visually loses its entire magazine when it runs out of ammunition
/:cl: