Skip to content

Network fixes and additions#506

Merged
PsyCommando merged 5 commits intoPersistentSS13:devfrom
NataKilar:fixes-midjan-testing
Jan 20, 2024
Merged

Network fixes and additions#506
PsyCommando merged 5 commits intoPersistentSS13:devfrom
NataKilar:fixes-midjan-testing

Conversation

@NataKilar
Copy link
Collaborator

Description of changes

Various network fixes and additions.

  • Adds network lockable extension for objects to copy network lock access without having a network device extension themselves
  • Adds network lockable crates and closets, producible in the industrial fabricator
  • Allows network locks to add individual account accesses to access patterns. Removes default behavior setting, replaces it with a toggle whether or not to require network connection to function
  • Makes network ID cards temporarily cache their access on connection (currently 30 minutes), so all access is not lost in the event of a network outage.
  • A runtime fixe with network money accounts

Authorship

Myself

@PsyCommando PsyCommando added the 🆕 enhancement New feature or request label Jan 19, 2024
@PsyCommando PsyCommando added this to the Outreach Map Pre-Release milestone Jan 19, 2024
@PsyCommando
Copy link
Collaborator

Psst, you forgot to add changelogs for the lockers stuff?

Copy link
Collaborator

@PsyCommando PsyCommando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve, but I'm a bit unsure about the way you're handling caching. I guess we'll have to keep a close eye on it. Also, have you tested those network closets? And how do you pick the network they connect to?

@NataKilar
Copy link
Collaborator Author

I'll approve, but I'm a bit unsure about the way you're handling caching. I guess we'll have to keep a close eye on it. Also, have you tested those network closets? And how do you pick the network they connect to?

Yes, I've tested the lockers. They don't connect to a network directly, they simply copy the access from a network lock. It's not a perfect system but it's better than a thousand extraneous network devices

@PsyCommando
Copy link
Collaborator

I'll approve, but I'm a bit unsure about the way you're handling caching. I guess we'll have to keep a close eye on it. Also, have you tested those network closets? And how do you pick the network they connect to?

Yes, I've tested the lockers. They don't connect to a network directly, they simply copy the access from a network lock. It's not a perfect system but it's better than a thousand extraneous network devices

I mean, a thousand might be pushing it. I don't think people would make that many closets? XP

@PsyCommando PsyCommando merged commit 66d2c73 into PersistentSS13:dev Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🆕 enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants