Code formatting, remove unused usings #111
Conversation
Code formatting, remove unused usings
|
Once again same as on you previous PR. White I appreciate the work, not sure yet how I feel about it. Pasting the response here for completeness sake. This has a lot of very opinionated changes in it. Frankly I am not exactly sure how I feel about merging it. Mainly, I don't use resharper so chances are I'll be changing everything again when I autoformat. Thanks for the effort but I don't see real value in it right now. Maybe if resharper was free, I could adapt to it. But this obviously open source project so I can't expect everybody to have it installed and conform to it's autoformat rules. |
|
Just my five cents on ReSharper use here. A while ago I've spent some time on doing pretty much the same - adding [NotNull] or [CanBeNull] everywhere in this project code clone. ReSharper has found a dozen places where NRE are quite possible. My guess would be to take into account these warnings and put additional null checks in the original code. And remove ReSharper references and attributes. So that we know that it's almost null-safe. Just a sort of static NRE check. There also were a number of places where fields could be made readonly etc. |
|
Yeah that sounds good to me. Would be happy to accept PR that adds some confidence to how this lib works. It would of course make sense to add unit tests as well. But that would again have to be a contribution. |
https://github.com/MohammadAsadi1372/MohammadAsadi.MasterService |
https://github.com/MohammadAsadi1372/MohammadAsadi.MasterService |
4 participants
No description provided.