Added blocking ConsoleServiceHost #49
Conversation
I copied over ConsoleRunHost from topshelf and modified it to work with DotNetCore.WindowsService library. The console service host blocks until the user hits the CancelKey(Ctrl+Break or Ctrl+C). The ExampleService.cs is updated to reflect the library update. The update allows for debugging of services which are push based rather than pull based.
|
This is my PR, I combined accounts ghost == japerr |
| namespace PeterKottas.DotNetCore.WindowsService.Example | ||
| { | ||
| public class ExampleService : IMicroService | ||
| public class ExampleService : IMicroService |
There was a problem hiding this comment.
It seems your settings for tabs are different to what the rest of the code bases uses, would you pls be able to reformat this to match existing formating?
There was a problem hiding this comment.
To help prevent this in the future, I added a solution level .editorconfig with formatting. EditorConfig standards are baked into VS2017. For *.cs files the indent style is set to space and the indent size is 4.
| public class ExampleService : IMicroService | ||
| { | ||
| private IMicroServiceController controller; | ||
| private IMicroServiceController _controller; |
There was a problem hiding this comment.
Could you pls rename this back? I know it's common naming convention but it's not really used anywhere else so it would be breaking what we have there atm.
| serviceHost.Run(); | ||
| break; | ||
| case ActionEnum.RunInteractive: | ||
| Start(config); |
There was a problem hiding this comment.
Why do we want this gone? Just checking if it won't break some of functionality people are already using.
There was a problem hiding this comment.
That line is replaced by lines 141 - 158 in ServiceRunner.cs. I moved the actual execute into ServiceRunner.Run so the new ConsoleServiceHost result is returned as the result of ServiceRunner.Run
|
Thanks a lot for this mate! Definitely looks good, there's just a few small things I noticed and left comments so that you could take a look at it. Cheers ;) |
|
Updated PR reflect code review changes |
|
This has been updated to reflect the code review changes. |
|
Hey mate, sorry been busy with some stuff. Going to merge and push that out now. Thanks again! |
2 participants
I copied over ConsoleRunHost from topshelf and modified it to work with
DotNetCore.WindowsService library. The console service host blocks until
the user hits the CancelKey(Ctrl+Break or Ctrl+C). The ExampleService.cs
is updated to reflect the library update. The update allows for
debugging of services which are push based rather than pull based.