Skip to content

Complain about bad autos in examples #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjbacchus wants to merge 1 commit into
base: gp_CodingConventions
Choose a base branch
from
Open

Complain about bad autos in examples #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sbn/codingconv/CodingConventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,8 @@ It should be used judiciously (and sparsely).

**[D]** In general, the use of `auto` is **discouraged**

TODO - agree, but we have quite a few dubious `auto`s in the examples in this very document. Let's practice what we preach

**[S]** The `auto` keyword can be safely used when the underlying type is _obvious_
from the code in the same line or the previous one.
In doubt, spell the type out instead.
Expand Down