Loosen rules on raw pointers #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
PetrilloAtWork
left a comment
PetrilloAtWork
left a comment
There was a problem hiding this comment.
I will keep this as is for now.
If I get a proper non-ROOT example where new is the best solution, I'll revisit.
(that is true for all these guidelines anyway: they will change)
| **[D]** The use of `new` operator is **discouraged**. | ||
| Data arrays should be stored in collections like `std::vector`. | ||
| Dynamic memory should be allocated via `std::make_unique()`. | ||
| Any use of `new` stored into a raw pointer must be accompanied by a justification, and explanation of the lifetime (`// deleted in destructor, this class is uncopyable` or `// single small instance throughout lifetime of program, deliberately leaked because XYZ`) |
Owner
There was a problem hiding this comment.
deleted in destructor, this class is uncopyable
spells std::unique_ptr<T> fData...
single small instance throughout lifetime of program, deliberately leaked because XYZ
... and here XYZ spells "ROOT". But to be honest as far as I remember even using ROOT histograms and trees I have managed to avoid new (I don't know if it's just because I let art::TFileService do the dirty job, but the point persists).
PetrilloAtWork
force-pushed
the
gp_CodingConventions
branch
from
bb2c237 to
add850e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.