This repository was archived by the owner on Jan 1, 2026. It is now read-only.
Fix #62: Implement async job execution#65
Merged
PetterS merged 5 commits intoPetterS:masterfrom Nov 23, 2021
Merged
Conversation
Owner
|
Hey this looks great! Let me see if I can find the time to review this properly this weekend. Thanks! |
Collaborator
Author
|
Note: with this patch, in the presence of potentially asynchronous code, the standard thing would be to call ctx.eval("/* some job launching */")
while ctx.execute_pending_job():
pass
ctx.eval("/* some more code */")If this back-and-forth between Python and JS is too slow, we could implement an |
PetterS
approved these changes
Nov 14, 2021
Owner
PetterS
left a comment
There was a problem hiding this comment.
Looks good!
This should be useful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #62.
Note that errors occurring in asynchronous code do not seem to be raised (even though the case
JS_ExecutePendingJob(...) < 0is handled). But this seems to be the case in the nativeqjsas well.EDIT: this seems to be a matter of using
JS_SetHostPromiseRejectionTracker, see bellard/quickjs#87. Should we use it, or maybe conditionally with a flag on the context (the question also applies to #64 ...)?