Skip to content

Fix version download URL#7

Closed
Sean-Kenneth-Doherty wants to merge 1 commit into
Phantomical:mainfrom
Sean-Kenneth-Doherty:codex/ksp-1.12.5-version
Closed

Fix version download URL#7
Sean-Kenneth-Doherty wants to merge 1 commit into
Phantomical:mainfrom
Sean-Kenneth-Doherty:codex/ksp-1.12.5-version

Conversation

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty commented May 17, 2026

Summary

  • fix the generated KSP-AVC DOWNLOAD URL so it uses https://

Upstream check

  • read README, CONTRIBUTING, CHANGELOG, LICENSE, and GitHub workflow metadata
  • checked open issues: none
  • checked open PRs: none

Validation

  • xmllint --noout src/KSPTextureLoader/KSPTextureLoader.csproj
  • git diff --check
  • verified the PR diff is limited to the missing colon in the generated DOWNLOAD URL

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title [codex] Fix KSP 1.12.5 version metadata Fix KSP 1.12.5 version metadata May 17, 2026
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/ksp-1.12.5-version branch May 18, 2026 02:01
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty restored the codex/ksp-1.12.5-version branch May 18, 2026 02:04
@Phantomical
Copy link
Copy Markdown
Owner

Phantomical commented May 18, 2026

I am not interested in the compatibility changes here. The existing compatibility list in the version file is fine, and not used by CKAN in any case. The URL fix is useful though.

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty force-pushed the codex/ksp-1.12.5-version branch from 5fb6e88 to ab1c435 Compare May 18, 2026 02:39
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty changed the title Fix KSP 1.12.5 version metadata Fix version download URL May 18, 2026
@Sean-Kenneth-Doherty
Copy link
Copy Markdown
Author

Thanks, that makes sense. I revised this to keep only the DOWNLOAD URL fix and dropped the compatibility-range changes.

@drewcassidy
Copy link
Copy Markdown

Sean is an LLM spambot, I recommend you close this

@Sean-Kenneth-Doherty Sean-Kenneth-Doherty marked this pull request as ready for review May 18, 2026 12:30
@Sean-Kenneth-Doherty Sean-Kenneth-Doherty deleted the codex/ksp-1.12.5-version branch May 18, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants