Don't close Syringe immediately #1982
Open
+32
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
TaranDahl
added
Interaction
Contributor
|
@ZivDero can you review this one? |
Contributor
It looks like a direct copy of what I did. There is a side-effect that if you close the game via task manager/taskkill it won't kill syringe, so you need to close that manually, though otherwise it works alright. |
ZivDero
approved these changes
Dec 2, 2025
ZivDero
requested changes
Dec 2, 2025
Contributor
ZivDero
left a comment
ZivDero
left a comment
There was a problem hiding this comment.
Actually, I guess per Phobos policty, need docs? 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep Syringe open until the game exits. Helps stop the client calling GameProcessExited when the "attach debugger" message appears.
Ported from Vinifera - originally done by ZivDero & secsome.