This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
==========================================
- Coverage 98.96% 98.81% -0.15%
==========================================
Files 34 34
Lines 1252 1266 +14
==========================================
+ Hits 1239 1251 +12
- Misses 13 15 +2
Continue to review full report at Codecov.
|
mibaumgartner
approved these changes
Feb 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short Description
Please give a short summary of the main points of this PR
PR Checklist
PR Implementer
This is a small checklist for the implementation details of this PR.
If you submit a PR, please look at these points (don't worry about the
RisingTeamand
Reviewerworkflows, the only purpose of those is to have a compact view ofthe steps)
If there are any questions regarding code style or other conventions check out our
summary.
__all__sections and__init__RisingTeam
RisingTeam workflow
Please make sure to communicate the current status of the pr.)
closes #IssueNumberat the bottom ifnot already in description)
Reviewer
Reviewer workflow
risingdesign conventions?Can you think of critical points which should be covered in an additional test?