Conversation
Added 4 new functions - pvc_start_live now internally only calls new pvc_setup_live and pvc_start_set_live, pvc_start_seq calls new pvc_setup_seq and pvc_start_set_seq. The pvc_setup_* functions proceed with all acq. setup, callback registration and buffer allocations, the pvc_start_set_* functions just reset FPS counters and start the acquisition. This allows finer control needed e.g. for a time-lapse acquisitions with Variable Timed exposure Mode (VTM), where the acq. should be set up only once and then for each frame is called set_param for PARAM_EXP_TIME with new value followed by acq. start capturing one frame with given exposure time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix relies on the changes in underlying pvc module.
Separated acquisition setup and start in pvc module and added 4 new functions - pvc_start_live now internally only calls new pvc_setup_live and pvc_start_set_live, pvc_start_seq calls new pvc_setup_seq and pvc_start_set_seq.
The pvc_setup_* functions proceed with all acq. setup and buffer allocations, the pvc_start_set_* functions just reset FPS counters and start the acquisition.
This allows finer control needed e.g. for a time-lapse acquisitions with Variable Timed exposure Mode (VTM), where the acq. should be set up only once and then for each frame is called set_param for PARAM_EXP_TIME with new value followed by acq. start capturing one frame with given exposure time.