Skip to content

Suppress warning of implicitly install package.xml file #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henningkayser merged 1 commit into from
Nov 13, 2019
Merged

Suppress warning of implicitly install package.xml file #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added resource/urdfdom_py
View file
Open in desktop
Empty file.
7 changes: 5 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from glob import glob
from setuptools import setup

package_name = 'urdfdom_py'
Expand All @@ -8,8 +9,10 @@
package_dir={'': 'src'},
packages=['urdf_parser_py', 'urdf_parser_py.xml_reflection'],
data_files=[
('scripts/display_urdf',
['package.xml']),
('share/ament_index/resource_index/packages',
['resource/' + package_name]),
('share/' + package_name, ['package.xml']),
('share/' + package_name + '/scripts', glob('scripts/display_urdf')),
Copy link

@henningkayser henningkayser Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this really install all scripts correctly? I would have thought we should rather fix the original CMakeLists.txt, but I'm fine if this works for now

Copy link

@henningkayser henningkayser Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see that per migration guide pure python packages should just run the setup.py

],
install_requires=['setuptools'],
zip_safe=True,
Expand Down