You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mlouielu , it might not fix this issue. tasklet_schedule would be only called by someone who wants to enqueue softirq task and trigger softirq handler which is trigger via rasie_softirq. It might be quite similar with Linux.
In our softirq design, it only handles softirqs in thread_softirqd. After this change, it might be failed timer task because it can't trigger softirq_handler. In short, thread_softirqd is a softirq handler, and it doesn't need to call tasklet_schedule.
The problem here isn't thread_softirqd, is thread_main, which will call tasklet_scheudle (but this is illegal). I think the root cause came from bitmap scheduler (due to the lake of rr scheudler, I can't test on it), but this patch can get an easy fixed so that we won't get other error when playing around minishell.
@mlouielu, I just wonder if the proposed fix got verified for both RR and bitmap scheduler policy yet. I defer to the analysis of @yenwu since he is hacking sched internals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This close #12. For discussion, please look comment in #12 .