fix: remove unused proxy code (closes #5)#6
Merged
Conversation
The HTTP proxy code was experimental and never wired into the CLI. mnemo's architecture uses MCP server + hooks for context injection, not HTTP interception. This removal eliminates the security vulnerability reported in #5. Changes: - Removed /proxy directory (server.go + server_test.go) - Updated CHANGELOG.md with removal entry - Updated SECURITY.md to remove proxy mention - Updated blocks.go comment to remove proxy reference The proxy had an authentication vulnerability where it read ANTHROPIC_API_KEY from environment and forwarded it with zero authentication, allowing any local process to consume API credits. Since the feature was unused and undocumented, removal is the correct fix. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
The GitHub Actions lint job was timing out with the default 1m timeout. This adds a minimal .golangci.yml config that increases the timeout to 5m. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Use --timeout=5m as inline arg instead of config file. Simpler and avoids version compatibility issues between golangci-lint v1 (CI) and v2 (local). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
0xRaghu
force-pushed
the
fix/remove-unused-proxy
branch
from
8fd196d to
ffc4a97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused HTTP proxy code that had a security vulnerability reported in #5.
Problem
The proxy code:
mnemo proxycommand exists)ANTHROPIC_API_KEYfrom environment and forwarded it with zero authenticationSolution
Complete removal of the proxy feature. mnemo's current architecture uses:
mnemo serve) for tool integrationmnemo inject) for context injectionChanges
/proxydirectory (server.go + server_test.go - 338 lines)Impact
Closes #5