Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the accuracy of agent online status detection for shared terminal features by introducing a new method to check real-time agent connectivity, both locally and across distributed instances via Redis. The changes ensure that the system more reliably reports whether agents are actually online, rather than relying solely on historical ping data.
Enhancements to agent online status detection:
IsAgentOnlinemethod toAgentHandlerininternal/api/handlers/agent.go, which checks for real-time agent connectivity locally and via Redis, providing a more accurate online status.Improvements to shared terminal logic:
internal/api/handlers/container.goto use the newIsAgentOnlinemethod, falling back to the previous LastPing check only if real-time connectivity is not found.