fix: auto-detect token/cluster for agent install/update#57
Merged
Conversation
- Add cmd/agent/cluster_config.go to read existing agent config from cluster - Update cmd/agent/install.go to use existing config if token/cluster name missing - Update cmd/agent/update.go to use existing config if token/cluster name missing - Allow running install/update without args if config exists in cluster
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the user experience for
pipeops agent install,update, andupgradecommands by automatically detecting the existing configuration from the cluster if one is already present.This means that if a user has an existing agent installation, they can simply run
pipeops agent updatewithout needing to provide the--tokenor--cluster-namearguments again. The CLI will fetch these values from thepipeops-agent-configsecret in thepipeops-systemnamespace.Changes
cmd/agent/cluster_config.go: Contains logic to fetchpipeops-agent-configsecret usingkubectl.cmd/agent/install.go:Argsvalidation now allows empty arguments if a valid cluster config is found.Runlogic attempts to use the cluster config if token/cluster name are missing.cmd/agent/update.go:Runlogic attempts to use the cluster config if token/cluster name are missing.Testing
kubectlexecution which is mocked in integration tests).make buildandmake lintpass.