Autodesk: [hd] Allow passing HdRendererCreateArgs to CreateDelegate() so IsSupported() can work correctly #3915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The main issue is that the
IsSupported()call checks the default Hgi, which isn't necessarily what one is trying to use. If the default isn't supported, then you can't create a render delegate even if a non-default is supported. We've encountered an issue (Windows laptop) where HgiGL fails to create due to an OpenGL version problem, but HgiVulkan works. It should be possible to use HgiVulkan (non-default) even when HgiGL (default) doesn't work. This solution addresses this issue.Note: You can set
HGI_ENABLE_VULKANto change the defaults, but that's not always an option, and isn't a proper solution as the environment variables are for development, not production.Example use case: https://github.com/Autodesk/hydra-viewport-toolbox/blob/a24d055fcf0d146249afb7e6a693fd5763355ca0/source/engine/renderIndexProxy.cpp#L49-L56
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)