Autodesk: [hdSt] Fix uninitialized locals passed to HdStUpdateInstancerData #3921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HdStUpdateInstancerData returns early when DirtyInstancer is not set, leaving output parameters unwritten. Initialize local variables to current member values before the call to preserve state in that case. Fixes random rendering test failures (disappearing geometry) on Linux.
ppenenko
reviewed
Dec 12, 2025
Comment on lines
+191
to
+198
| HdStUpdateInstancerData(sceneDelegate->GetRenderIndex(), | ||
| renderParam, | ||
| this, | ||
| drawItem, | ||
| &_sharedData, | ||
| *dirtyBits, | ||
| &displayOpacityFromInstancer); | ||
| _displayOpacityFromInstancer = displayOpacityFromInstancer; |
Contributor
There was a problem hiding this comment.
Previously, if DirtyInstancer was not set, the function would return early and leave the locals like displayOpacityFromInstancer uninitialized, so the prim's members like _displayOpacityFromInstancer would be populated with garbage. This triggered a bunch of unit test failures for us on Linux only, mostly testUsdImagingGL*.
Collaborator
|
Filed as internal issue #USD-11713 (This is an automated message. See here for more information.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
HdStUpdateInstancerData returns early when DirtyInstancer is not set, leaving output parameters unwritten. Initialize local variables to current member values before the call to preserve state in that case.
Fixes random rendering test failures (disappearing geometry) on Linux.
Link to proposal (if applicable)
Fixes Issue(s)
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)