Add units selection for UsdGeomCamera #3922
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'tenths of a scene unit' behavior for camera geometry causes no end of confusion and frustration in mixed-unit pipelines, as well as being a source of bugs in implementations. This PR adds a attribute to UsdGeomCamera to allow selecting between 'sceneTenths' (the default) and 'millimeters'. The latter specifies that all camera geometry (i.e. aperture, focal length) is specified in millimeters, and that renderers must handle conversion from millimeters to stage units themselves.
anderslanglands
force-pushed
the
alanglands/camera-units-token
branch
from
6fa9663 to
07c7c44
Compare
Collaborator
|
Filed as internal issue #USD-11714 (This is an automated message. See here for more information.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The 'tenths of a scene unit' behavior for camera geometry causes no end of confusion and frustration in mixed-unit pipelines, as well as being a source of bugs in implementations.
This PR adds a attribute to UsdGeomCamera to allow selecting between 'sceneTenths' (the default) and 'millimeters'. The latter specifies that all camera geometry (i.e. aperture, focal length) is specified in millimeters, and that renderers must handle conversion from millimeters to stage units themselves.
Checklist
I have created this PR based on the dev branch
I have followed the coding conventions
I have added unit tests that exercise this functionality (Reference:
testing guidelines)
I have verified that all unit tests pass with the proposed changes
I have submitted a signed Contributor License Agreement (Reference:
Contributor License Agreement instructions)