Fix to ParameterBindingValidationException exception thrown when $PSU…#383
Open
stuart938503 wants to merge 3 commits intoPlagueHO:mainfrom
Open
Fix to ParameterBindingValidationException exception thrown when $PSU…#383stuart938503 wants to merge 3 commits intoPlagueHO:mainfrom
stuart938503 wants to merge 3 commits intoPlagueHO:mainfrom
Conversation
PlagueHO
requested changes
Nov 2, 2021
Owner
PlagueHO
left a comment
There was a problem hiding this comment.
Hi @stuart938503 - can you add an entry to the CHANGELOG.md for this change and reference the issue (see previous change formats). Thank you!
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stuart938503)
source/prefix.ps1, line 20 at r1 (raw file):
else { if (! (Test-Path -Path (Join-Path -Path $script:LabBuidlerModuleRoot -ChildPath $culture)))
For consistency, can you use -not syntax?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ICulture not en-US #382
@PlagueHO
This change is