Skip to content
This repository was archived by the owner on Jul 7, 2025. It is now read-only.

Conversation

@Raptorandusz094
Copy link

@Raptorandusz094 Raptorandusz094 requested a review from z-x March 3, 2025 12:09
Copy link
Contributor

@z-x z-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you need to npm run build and also commit the build outcome in the repository and you need to update the module version in template-values.json to be able to release it.

There is another problem with this approach - you are hardcoding the color. We are using Tailwind variables to color elements but this won't work with your code. If someone will be using components module and would like to change the colour of the calendar they would need to edit the code instead overwriting the variables.

@Raptorandusz094
Copy link
Author

@z-x done , i don't confidence about my approach now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants