Apply withCredentials option globally #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR applies the withCredentials: true option globally to the axios instance configuration, eliminating the need to specify it in each individual HTTP request. This change consolidates credential handling in a single location for better maintainability.
- Adds
withCredentials: trueto the global axios instance configuration - Removes redundant
withCredentials: truefrom individual API calls across the application - Maintains the same authentication behavior while reducing code duplication
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| utils/axios.instance.js | Adds global withCredentials: true configuration to PoPoAxios instance |
| utils/file-upload.js | Removes local withCredentials from ImageUpload and CsvUpload functions |
| pages/user/index.jsx | Removes withCredentials from user search API call |
| pages/user/[uuid].jsx | Removes withCredentials from user detail fetch and update operations |
| pages/place/update/[uuid].jsx | Removes withCredentials from place update API call |
| pages/place/reservation/index.jsx | Removes withCredentials from place reservation fetch operations |
| pages/place/reservation/create.jsx | Removes withCredentials from auth verification and reservation creation |
| pages/place/create.jsx | Removes withCredentials from place creation API call |
| pages/login.jsx | Removes withCredentials from login and token verification operations |
| pages/introduce/club/update/[uuid].jsx | Removes withCredentials from club update operation |
| pages/introduce/club/create.jsx | Removes withCredentials from club creation operation |
| pages/introduce/association/update/[uuid].jsx | Removes withCredentials from association update operation |
| pages/introduce/association/create.jsx | Removes withCredentials from association creation operation |
| pages/equipment/update/[uuid].jsx | Removes withCredentials from equipment update operation |
| pages/equipment/reservation.jsx | Removes withCredentials from equipment reservation fetch operations |
| pages/equipment/create.jsx | Removes withCredentials from equipment creation operation |
| pages/board/whitebook.jsx | Removes withCredentials from whitebook fetch operation |
| pages/board/setting.jsx | Removes withCredentials from settings save operation |
| pages/board/rc-students-list.jsx | Removes withCredentials from RC students operations |
| pages/board/notice/update/[id].jsx | Removes withCredentials from notice update operation |
| pages/board/notice/create.jsx | Removes withCredentials from notice creation operation |
| pages/board/calendar/update/[id].jsx | Removes withCredentials from calendar update operation |
| pages/board/calendar/create.jsx | Removes withCredentials from calendar creation operation |
| pages/board/benefit/discount/update/[id].jsx | Removes withCredentials from discount update operation |
| pages/board/benefit/discount/create.jsx | Removes withCredentials from discount creation operation |
| pages/board/benefit/affiliate/update/[id].jsx | Removes withCredentials from affiliate update operation |
| pages/board/benefit/affiliate/create.jsx | Removes withCredentials from affiliate creation operation |
| components/user/user.update.modal.jsx | Removes withCredentials from user update modal operation |
| components/user/user.create.modal.jsx | Removes withCredentials from user creation modal operation |
| components/place/place.reservation.wait.table.jsx | Removes withCredentials from bulk reservation acceptance |
| components/place/place.reservation.confirm.modal.jsx | Removes withCredentials from reservation status update |
| components/navbar/menu.item.user.jsx | Removes withCredentials from token verification and logout |
| components/layout/layout.auth.with.jsx | Removes withCredentials from admin token verification |
| components/equipment/equipment.reservation.confirm.modal.jsx | Removes withCredentials from equipment reservation status update |
| components/common/delete.confirm.modal.jsx | Removes withCredentials from delete operations |
| components/common/csv-upload.form.jsx | Removes withCredentials from RC students sync operation |
| components/board/whitebook/whitebook.update.modal.jsx | Removes withCredentials from whitebook update operation |
| components/board/whitebook/whitebook.create.modal.jsx | Removes withCredentials from whitebook creation operation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withCredentials: true를 전역적으로 사용합니다