Skip to content

Conversation

@khkim6040
Copy link
Member

@khkim6040 khkim6040 commented Aug 9, 2025

워크플로우 트리거 조건 및 동시성 제어

  • 이제 push가 아니라 PR을 열 때 워크플로우가 트리거 됨. PR이 올라간 뒤에는 push할 때마다 트리거
    • 코드 변경을 dev에 반영하고 싶으면 PR을 올리자
    • 무지성 dev push x 로컬에서 테스트하고 올리자
    • 다른사람들이 어떤 작업을 하고 있는지 알 수 있음
    • 준비가 안되었다면 PR 올린 뒤 draft로 변경하고 계속 작업
  • 같은 PR에서 워크플로우는 하나씩만 돌아감
    • push를 했는데 워크플로우가 이미 돌고있다? 그거 캔슬함
    • 서로 다른 PR에서는 상관 X
    • 아래와 같이 캔슬됨
image image
  • docker_build_and_push 잡은 모든 워크플로우 통틀어서 유일하게 하나만 돌아감
    • 도커 이미지 빌드&원격 push 동시에 해서 swarm에서 latest 가져오는게 뭔가 꼬였던 것 같아서 이렇게 설정했음

@khkim6040 khkim6040 requested a review from Copilot August 9, 2025 09:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces concurrency control for GitHub Actions workflows and updates the trigger conditions to focus on pull requests instead of direct pushes to the main branch. The changes aim to improve workflow efficiency and prevent conflicts during CI/CD operations.

  • Modified workflow triggers to activate on pull requests to main branch instead of direct pushes
  • Added concurrency controls to prevent multiple workflows from running simultaneously on the same PR
  • Implemented global concurrency limits for Docker build operations to prevent deployment conflicts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/github-action.yaml Updated workflow triggers and added two-level concurrency control (PR-level and global Docker build)
.gitattributes Added line ending normalization configuration

@khkim6040 khkim6040 merged commit 24f0188 into main Aug 9, 2025
4 checks passed
@khkim6040 khkim6040 deleted the feat/github-workflow-concurrency branch August 9, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants