This repository was archived by the owner on Sep 10, 2025. It is now read-only.
fix(home): fix see all sometimes opening empty screen #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this episode of Slate IDs Don't Matter it turned out we load slates by slate id on the details screen. And if you click "See all" while Home is refreshing, you'll start the screen with an id, but when the network request comes back all the ids will change and the screen won't find a slate with this id and will show and empty screen.
In this case opening by index is more reliable. The only bad things that could happen is if we remove a slate or reorder them. Then someone could see a different slate than the one they clicked. Unless we reorder slates on each refresh, they should be able to just go back and reopen to get the correct one.
References
PR Checklist
Setup:
Conventional Commits standard
Review: