Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@marcin-kozinski
Copy link
Collaborator

In this episode of Slate IDs Don't Matter it turned out we load slates by slate id on the details screen. And if you click "See all" while Home is refreshing, you'll start the screen with an id, but when the network request comes back all the ids will change and the screen won't find a slate with this id and will show and empty screen.

In this case opening by index is more reliable. The only bad things that could happen is if we remove a slate or reorder them. Then someone could see a different slate than the one they clicked. Unless we reorder slates on each refresh, they should be able to just go back and reopen to get the correct one.

References

PR Checklist

Setup:

  • Described changes for automated release notes in PR title using
    Conventional Commits standard
  • Self Review (review, clean up, documentation)
  • Basic Self QA

Review:

  • Code Review approved

@marcin-kozinski marcin-kozinski added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit def09ef Jan 10, 2025
4 checks passed
@marcin-kozinski marcin-kozinski deleted the fix-slate-details branch January 10, 2025 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants