Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@marcin-kozinski
Copy link
Collaborator

Add a "Notes" chip to the Saves filter carousel:

  • shows a placeholder text instead of notes for now,
  • hidden behind a dev feature flag.

References

PR Checklist

Setup:

  • Described changes for automated release notes in PR title using
    Conventional Commits standard
  • Self Review (review, clean up, documentation)
  • Basic Self QA
  • Feature flagged as needed to ensure this specific code is beta and production ready

Review:

  • Code Review approved

@marcin-kozinski marcin-kozinski added the notes Move to "Notes" section in release notes. label Jan 15, 2025
Copy link
Contributor

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

@kschelonka kschelonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's a linter error but lgtm otherwise

@marcin-kozinski
Copy link
Collaborator Author

Thanks! Yea, the linter is a bit too eager, the problem it found will go away once Smartling updates the translated files. So in #137 I've updated the linter configuration to ignore translated files.

@marcin-kozinski marcin-kozinski added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit bf66071 Jan 16, 2025
3 of 4 checks passed
@marcin-kozinski marcin-kozinski deleted the notes-filter branch January 16, 2025 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

notes Move to "Notes" section in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants