Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@marcin-kozinski
Copy link
Collaborator

@marcin-kozinski marcin-kozinski commented Dec 3, 2024

Clean up unused functionality and other tech debt around our last remaining usage of SyncCache/DataSourceCache.

  • It wasn't using diffs produced by the built in usage of DiffUtil.
    • Removed the configuration option that was effectively always false and removed the effectively unused code and callback parameter.
  • It wasn't using merges or dependencies.
    • This simplified loading, checking loading status and error handling a bunch.
    • "Ignore white-space changes" might be helpful in reviewing this.
  • There were a few more unused methods.
  • Moved updating StateFlow value to the official update extension function, from our bespoke edit wrapper.
  • Tweaked implementation of NoCompareMutableStateFlow to avoid inheritance explicitly discouraged in (Mutable)StateFlow docs.

References

PR Checklist

Setup:

  • Described changes for automated release notes in PR title using
    Conventional Commits standard
  • Self Review (review, clean up, documentation)
  • Basic Self QA

Review:

  • Code Review approved

Copy link
Contributor

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcin-kozinski marcin-kozinski added this pull request to the merge queue Dec 5, 2024
Merged via the queue into main with commit e2ee246 Dec 5, 2024
4 checks passed
@marcin-kozinski marcin-kozinski deleted the clean-up-sync-cache branch December 5, 2024 08:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants