Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@marcin-kozinski
Copy link
Collaborator

@marcin-kozinski marcin-kozinski commented Dec 17, 2024

Finish NotesRepository by backing it with real queries and mutations sent to the graph (via the sync engine) and an in memory cache, so we can create/update/delete/open locally without requiring a full data refresh, complete with pagination.

References

PR Checklist

Setup:

  • Described changes for automated release notes in PR title using
    Conventional Commits standard
  • Self Review (review, clean up, documentation)
  • Basic Self QA
  • Feature flagged as needed to ensure this specific code is beta and production ready

Review:

  • Code Review approved
  • If modified GraphQL spec or queries, checked the usage file for invalid or no longer used definitions and cleaned it up if necessary

@marcin-kozinski marcin-kozinski added the notes Move to "Notes" section in release notes. label Dec 17, 2024
Copy link
Contributor

@nzeltzer nzeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcin-kozinski marcin-kozinski force-pushed the notes-graphql branch 2 times, most recently from 764cc25 to 10ccbd8 Compare December 18, 2024 10:58
@marcin-kozinski marcin-kozinski added this pull request to the merge queue Dec 18, 2024
Merged via the queue into main with commit 290cf4b Dec 18, 2024
4 checks passed
@marcin-kozinski marcin-kozinski deleted the notes-graphql branch December 18, 2024 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

notes Move to "Notes" section in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants