fix(openapi): use correct tag type, maintain operation order #1092
fix(openapi): use correct tag type, maintain operation order #1092Naramsim merged 9 commits intoPokeAPI:masterfrom
Conversation
| "description": "Pokémon are the creatures that inhabit the world of the Pokémon games", | ||
| "externalDocs": { | ||
| "description": "Fine more info here", | ||
| "url": "https://bulbapedia.bulbagarden.net/wiki/Pok%C3%A9mon", |
There was a problem hiding this comment.
Hi, thanks for the PR!
I see that we have this description in the api.py file as well:
Line 107 in f464535
Would it be possible to use that one so to avoid duplication?
There was a problem hiding this comment.
@Naramsim Which tag description, pokemon?
There was a problem hiding this comment.
@Naramsim I updated the tag descriptions with the ones from the API. Let me know if you see any that I missed.
|
Hi, my question was a bit different. Is it possible not to write a hardcoded string but to fetch the descriptions with code from the api.py file? I see that |
|
@Naramsim I see... that sounds pretty doable but I'm total python noob 🤓. I think the duplication is okay in this instance since tags and operations are distinct concepts. |
|
Ok! I'll merge this PR, but if you have time and will maybe you can look into how to dynamically get the description |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
|
The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data. |
SORT_OPERATIONStoFalseRelated to #1087