Fix: OpenAPI Schema for held_items#1248
Conversation
|
@PraaneshSelvaraj you'll also need to regenerate the spec to apply your changes. If I remember correctly running the command below should do it. make openapi-generate@Naramsim would it be a bad idea to add openapi instructions some where in the docs? |
|
@Indyandie I regenerated openapi.yml. I only changed |
|
There have been lots of updates since the last generation. @Naramsim maybe we can add some automation to regenerate the spec anytime there are relevant changes. |
|
@Indyandie Hey, Is this PR good to merge or should I add something else? |
|
Your changes should fix the issue. |
|
@Naramsim Hey, PR is good to merge now. |
|
A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data. |
This PR updates the
held_itemsschema in thePokemonDetailresponse to correctly reflect it as an array of objects (not a single object), matching actual API responses.Fixes #1247