Disables throttling #464
Merged
Disables throttling #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How is this going to affect the Fair Use Policy described in the pokeapi.co documentation? |
Member
Author
|
It won't since we are not using anymore this python server to serve the APIs, we are using static hosting on Firebase. PS: And now with firebase, there is no throttling at all. |
This was referenced Dec 17, 2019
phalt
requested changes
Dec 18, 2019
Member
phalt
left a comment
phalt
left a comment
There was a problem hiding this comment.
May as well delete it? We can always get it back through git history
Naramsim
requested review from
GregHilmes,
Kronopt,
neverendingqs and
tasadurian
Kronopt
approved these changes
Jan 17, 2020
tasadurian
approved these changes
Jan 17, 2020
Member
Author
|
@phalt, can you unlock? |
phalt
approved these changes
Jan 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the entire API is now static files, we don't need anymore any throttling. This simplifies also updating data in the
api-datarepo.