-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Meltan, Melmetal, Double Iron Bash move and Let's Go Eevee and Let's Go Pikachu version groups #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks a lot for the hard work @ks129, I saw you also opened a PR towards veekun/pokedex, that the right thing! :) Let's see if one of their maintainers comes back at us and approves the PR over there. If so I would be happy to merge your contribution! If they don't come back maybe we could fork veekun/pokedex to our organization and merge your contribs there. And then we could simply use the forked data. Let's give Veekun at least one or two weeks. |
|
@Naramsim One note: Veekun changes is little bit different, due there I didn't added new body shapes and habitats (unknown), due this built successfully without these, but PokeAPI building gave error when these values was empty. |
|
Ok, good to know, do you think is possible to have the same data here and there? Maybe by changing a bit our code and handling the build error? |
|
@Naramsim now should all changes same here and there |
|
There are conflicts now against the master branch. Can we link the veekun issue related to this here so we can track it? |
|
PR opened over veekun/pokedex: veekun/pokedex#292 |
|
The conflicts are trivial to fix |
|
Hi @ks129, sorry for coming back after such a long time, but as you've seen Veekun didn't want to merge your data. We recently created a fork of Veekun at https://github.com/PokeAPI/pokedex. If you are still interested in bringing in your changes to PokeAPI, could you please open a PR over there with the new data and then a new clean one here? Thanks a lot!! |
|
Closing since we merged other PRs that brought in the same data. |
Like title say... all of these added. Used #466 branch.