Skip to content

Conversation

@ks129
Copy link

@ks129 ks129 commented Jan 20, 2020

Like title say... all of these added. Used #466 branch.

@ks129 ks129 requested a review from Naramsim January 20, 2020 18:10
@Naramsim
Copy link
Member

Thanks a lot for the hard work @ks129, I saw you also opened a PR towards veekun/pokedex, that the right thing! :) Let's see if one of their maintainers comes back at us and approves the PR over there. If so I would be happy to merge your contribution!

If they don't come back maybe we could fork veekun/pokedex to our organization and merge your contribs there. And then we could simply use the forked data. Let's give Veekun at least one or two weeks.

@ks129
Copy link
Author

ks129 commented Jan 21, 2020

@Naramsim One note: Veekun changes is little bit different, due there I didn't added new body shapes and habitats (unknown), due this built successfully without these, but PokeAPI building gave error when these values was empty.

@Naramsim
Copy link
Member

Ok, good to know, do you think is possible to have the same data here and there? Maybe by changing a bit our code and handling the build error?

@ks129
Copy link
Author

ks129 commented Jan 25, 2020

@Naramsim now should all changes same here and there

@phalt
Copy link
Member

phalt commented Feb 17, 2020

There are conflicts now against the master branch.

Can we link the veekun issue related to this here so we can track it?

@Naramsim
Copy link
Member

PR opened over veekun/pokedex: veekun/pokedex#292

@Naramsim
Copy link
Member

The conflicts are trivial to fix

@Naramsim
Copy link
Member

Hi @ks129, sorry for coming back after such a long time, but as you've seen Veekun didn't want to merge your data. We recently created a fork of Veekun at https://github.com/PokeAPI/pokedex.

If you are still interested in bringing in your changes to PokeAPI, could you please open a PR over there with the new data and then a new clean one here?

Thanks a lot!!

@Naramsim
Copy link
Member

Closing since we merged other PRs that brought in the same data.

@Naramsim Naramsim closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants