Skip to content

Corrected Sapphire spelling broke type fetching #158

@BitTim

Description

@BitTim

After the this pull request has been merged into PokeApi, type fetching no longer works since it throws the following exception:

io.ktor.serialization.JsonConvertException: Illegal input: Field 'ruby-saphire' is required for type with serial name 'co.pokeapi.pokekotlin.model.GenerationIiiTypeSprites', but it was missing at path: $.sprites.generation-iii
    at io.ktor.serialization.kotlinx.KotlinxSerializationConverter.deserialize(KotlinxSerializationConverter.kt:79)
    at io.ktor.serialization.ContentConverterKt$deserialize$$inlined$map$1$2.emit(Emitters.kt:51)
    at kotlinx.coroutines.flow.FlowKt__BuildersKt$asFlow$$inlined$unsafeFlow$3.collect(SafeCollector.common.kt:111)
    at io.ktor.serialization.ContentConverterKt$deserialize$$inlined$map$1.collect(SafeCollector.common.kt:109)
    at kotlinx.coroutines.flow.FlowKt__ReduceKt.firstOrNull(Reduce.kt:247)
    at kotlinx.coroutines.flow.FlowKt.firstOrNull(Unknown Source:1)
    at io.ktor.serialization.ContentConverterKt.deserialize(ContentConverter.kt:113)
    at io.ktor.client.plugins.contentnegotiation.ContentNegotiationKt.ContentNegotiation$lambda$0$convertResponse(ContentNegotiation.kt:284)
    at io.ktor.client.plugins.contentnegotiation.ContentNegotiationKt.access$ContentNegotiation$lambda$0$convertResponse(ContentNegotiation.kt:1)
    at io.ktor.client.plugins.contentnegotiation.ContentNegotiationKt$ContentNegotiation$2$2.invokeSuspend(ContentNegotiation.kt:299)
    at io.ktor.client.plugins.contentnegotiation.ContentNegotiationKt$ContentNegotiation$2$2.invoke(Unknown Source:19)
    at io.ktor.client.plugins.contentnegotiation.ContentNegotiationKt$ContentNegotiation$2$2.invoke(Unknown Source:10)
    at io.ktor.client.plugins.api.TransformResponseBodyHook$install$1.invokeSuspend(KtorCallContexts.kt:113)
    at io.ktor.client.plugins.api.TransformResponseBodyHook$install$1.invoke(Unknown Source:11)
    at io.ktor.client.plugins.api.TransformResponseBodyHook$install$1.invoke(Unknown Source:6)
    at io.ktor.util.pipeline.DebugPipelineContext.proceedLoop(DebugPipelineContext.kt:79)
    at io.ktor.util.pipeline.DebugPipelineContext.proceed(DebugPipelineContext.kt:57)
    at io.ktor.client.HttpClient$4.invokeSuspend(HttpClient.kt:1401)
    at io.ktor.client.HttpClient$4.invoke(Unknown Source:11)
    at io.ktor.client.HttpClient$4.invoke(Unknown Source:6)
    at io.ktor.util.pipeline.DebugPipelineContext.proceedLoop(DebugPipelineContext.kt:79)
    at io.ktor.util.pipeline.DebugPipelineContext.proceed(DebugPipelineContext.kt:57)
    at io.ktor.client.plugins.ReceiveError$install$1.invokeSuspend(HttpCallValidator.kt:165)
    at io.ktor.client.plugins.ReceiveError$install$1.invoke(Unknown Source:11)
    at io.ktor.client.plugins.ReceiveError$install$1.invoke(Unknown Source:6)
    at io.ktor.util.pipeline.DebugPipelineContext.proceedLoop(DebugPipelineContext.kt:79)
    at io.ktor.util.pipeline.DebugPipelineContext.proceed(DebugPipelineContext.kt:57)
    at io.ktor.util.pipeline.DebugPipelineContext.execute$ktor_utils(DebugPipelineContext.kt:63)
    at io.ktor.util.pipeline.Pipeline.execute(Pipeline.kt:92)
    at io.ktor.client.call.HttpClientCall.bodyNullable(HttpClientCall.kt:99)
    at co.pokeapi.pokekotlin.PokeApi.getType(PokeApi.kt:3218)

I am going to open a PR with the fix in a second as well, since it is a very simple one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions