Open
Conversation
Mysticial
reviewed
Apr 10, 2026
| const char* zip_path, | ||
| const char* target_dir, | ||
| std::function<void(int)> progress_callback, | ||
| std::function<bool()> is_cancelled |
Collaborator
There was a problem hiding this comment.
Without having looked much at the surrounding code, how difficult do you think it would be to re-architect this to use the Cancellable(Scope) class? Since that was designed specifically for this kind of async cancel stuff.
…tialize remote_metadata for each Download button.
… into their own class
…d will throw InternalProgramError if it fails for other reasons.
…re it is always a shared_ptr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This only adds the ability to download the resource from the Settings page. It doesn't yet prompt you when you start a program.
Another note: right now the URL to the resources points to my own repo. I assume we will want the URLs pointing to the official Packages releases.