Add day/night detection and weather detection to za benchsit#1177
Open
Developer-Butters wants to merge 10 commits intoPokemonAutomation:mainfrom
Open
Add day/night detection and weather detection to za benchsit#1177Developer-Butters wants to merge 10 commits intoPokemonAutomation:mainfrom
Developer-Butters wants to merge 10 commits intoPokemonAutomation:mainfrom
Conversation
Created a day/night detection program that looks for the crecent moon on the minimap. added logic to bench sit to allow the user to only run forward during specifically day/night and specific weather patterns.
updated the window formatting and locked the filters while running because I don't want them to break somehow.
updated the detector to detect the color change on the left side of the main map. the color is dependent on the day night cycle. updated bench sit to use both weather and day/night detection to improve shiny farming rates of different pokemon.
my initial commits had a memory issue. these changes fix that.
…ource into add_day_night_ot_becnh_sit
Mysticial
reviewed
Apr 15, 2026
| "PokemonLZA:ShinyHunt-BenchSit", | ||
| STRING_POKEMON + " LZA", "Bench Sit", | ||
| "Programs/PokemonLZA/ShinyHunt-BenchSit.html", | ||
| "Shiny hunt by repeatedly sitting on a bench to reset spawns.", |
Collaborator
There was a problem hiding this comment.
Can you disable your code formatter? It really likes to mess everything up.
Contributor
Author
There was a problem hiding this comment.
yes, I'll go grab the original file this evening and re-add my code once I disable. I tried to fix it manually last night but it didn't work and it was too late for me to keep changing stuff
Contributor
Author
There was a problem hiding this comment.
fixed the formatting with the most recent push, but I need to do more testing to confirm some errors relating to the detector. for some reason the detector appears to be moving off the screen and causing a memory issue. Marking this PR as a draft for the time being.
Copied and pasted the original benchsit programs to the local repo to try to fix formatting. will confirm with diff on github. updated the detector to more clearly define day vs night added to the open menu portion of the detection functions a push left all the way so that the detector accurately detects the color of the border and doesn't get a false positive day or night. made the detector square persistent for testing purposes.
…ource into add_day_night_ot_becnh_sit
Developer-Butters
force-pushed
the
add-day-night-to-za-bench
branch
from
76e02de to
b3837b5
Compare
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
refined the detector and removed some debugging tools
|
Azure Pipelines: 2 pipeline(s) were filtered out due to trigger conditions. |
…ource into add_day_night_ot_becnh_sit
Contributor
Author
|
I ran the program for about 8 hours and didn't get the QT creator crash I had been getting before, so I believe this is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new Day/Night detector for Pokémon Legends: Z-A and integrates it into the Bench Sit shiny hunting program. I also added weather detection from the weather finder.
The detector samples color data directly from the main map to determine if the cycle is day or night.
The Bench Sit program now allows the user to define specific weather and time conditions before the character runs forward. this should allow the user to more effectively shiny hunt specific Pokemon like Lucario.