Skip to content

Reorganize FRLG RNG code #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mysticial merged 3 commits into from
Apr 18, 2026
Merged

Reorganize FRLG RNG code #1190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbdd2af
reorganize FRLG RNG programs
theastrogoth Apr 17, 2026
c7af71d
Merge branch 'main' into tag/rng-organization
theastrogoth Apr 17, 2026
e739f5b
expose move_to_user
theastrogoth Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions SerialPrograms/Source/NintendoSwitch/Programs/NintendoSwitch_GameEntry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ void resume_game_from_home(
bool skip_home_press = false
);

void move_to_user(ProControllerContext& context, uint8_t user_slot);
void move_to_user(JoyconContext& context, uint8_t user_slot);

void start_game_from_home(
ConsoleHandle& console, ProControllerContext& context,
bool tolerate_update_menu,
Expand Down
210 changes: 177 additions & 33 deletions SerialPrograms/Source/Pokemon/Pokemon_AdvRng.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
*/

#include <cstddef>
#include <algorithm>
#include "Pokemon_AdvRng.h"

namespace PokemonAutomation{
Expand All @@ -14,7 +15,7 @@ uint32_t increment_internal_rng_state(uint32_t& state){
return state * 0x41c64e6d + 0x6073;
}

AdvRngState rngstate_from_internal_state(uint16_t seed, uint64_t advances, uint32_t& state, RngMethod method){
AdvRngState rngstate_from_internal_state(uint16_t seed, uint64_t advances, uint32_t& state, AdvRngMethod method){
uint32_t s0 = state;
uint32_t s1 = increment_internal_rng_state(s0);
uint32_t s2 = increment_internal_rng_state(s1);
Expand All @@ -24,7 +25,7 @@ AdvRngState rngstate_from_internal_state(uint16_t seed, uint64_t advances, uint3
return {seed, advances, method, s0, s1, s2, s3, s4};
}

AdvRngState rngstate_from_seed(uint16_t& seed, uint64_t advances, RngMethod method){
AdvRngState rngstate_from_seed(uint16_t seed, uint64_t advances, AdvRngMethod method){
uint32_t state = seed;
state = increment_internal_rng_state(state);
for (uint64_t i=0; i<advances; i++){
Expand All @@ -51,20 +52,20 @@ uint8_t gender_value_from_pid(uint32_t& pid){
return pid & 0xff;
}

Gender gender_from_gender_value(uint8_t gender_value, uint8_t threshold){
return (gender_value <= threshold) ? Gender::Female : Gender::Male;
AdvGender gender_from_gender_value(uint8_t gender_value, uint8_t threshold){
return (gender_value <= threshold) ? AdvGender::Female : AdvGender::Male;
}

Nature nature_from_pid(uint32_t& pid){
return Nature (pid % 25);
AdvNature nature_from_pid(uint32_t& pid){
return AdvNature (pid % 25);
}

Ability ability_from_pid(uint32_t& pid){
return Ability (pid % 2);
AdvAbility ability_from_pid(uint32_t& pid){
return AdvAbility (pid % 2);
}

IvGroup iv_group_from_state(uint32_t& state){
IvGroup ivgroup;
AdvIvGroup iv_group_from_state(uint32_t& state){
AdvIvGroup ivgroup;
uint32_t remainingbits = state;

ivgroup.iv0 = (remainingbits & 0xfffff) % 32;
Expand All @@ -77,32 +78,32 @@ IvGroup iv_group_from_state(uint32_t& state){
return ivgroup;
}

AdvPokemonResult pokemon_from_state(AdvRngState& state, RngMethod method = RngMethod::Method1){
AdvPokemonResult pokemon_from_state(AdvRngState& state, AdvRngMethod method = AdvRngMethod::Method1){
uint32_t pid = pid_from_states(state.s0, state.s1);
uint8_t gender = gender_value_from_pid(pid);
Nature nature = nature_from_pid(pid);
Ability ability = ability_from_pid(pid);
AdvNature nature = nature_from_pid(pid);
AdvAbility ability = ability_from_pid(pid);

IvGroup ivgroup1;
IvGroup ivgroup2;
AdvIvGroup ivgroup1;
AdvIvGroup ivgroup2;
switch(method){

case RngMethod::Method2:
case AdvRngMethod::Method2:
ivgroup1 = iv_group_from_state(state.s3);
ivgroup2 = iv_group_from_state(state.s4);
break;
case RngMethod::Method4:
case AdvRngMethod::Method4:
ivgroup1 = iv_group_from_state(state.s2);
ivgroup2 = iv_group_from_state(state.s4);
break;
case RngMethod::Method1:
case AdvRngMethod::Method1:
default:
ivgroup1 = iv_group_from_state(state.s2);
ivgroup2 = iv_group_from_state(state.s3);
break;
}

IVs ivs;
AdvIVs ivs;
ivs.hp = ivgroup1.iv0;
ivs.attack = ivgroup1.iv1;
ivs.defense = ivgroup1.iv2;
Expand All @@ -113,26 +114,26 @@ AdvPokemonResult pokemon_from_state(AdvRngState& state, RngMethod method = RngMe
return {pid, gender, nature, ability, ivs};
}

ShinyType shiny_type_from_pid(uint32_t pid, uint16_t tid_xor_sid){
AdvShinyType shiny_type_from_pid(uint32_t pid, uint16_t tid_xor_sid){
uint16_t pid0 = pid >> 16;
uint16_t pid1 = pid & 0xffff;
uint16_t pid_xor (pid0 ^ pid1);

if (pid_xor == tid_xor_sid){
return ShinyType::Square;
return AdvShinyType::Square;
}else if ((pid_xor ^ tid_xor_sid) < 8){
return ShinyType::Star;
return AdvShinyType::Star;
}else{
return ShinyType::Normal;
return AdvShinyType::Normal;
}
}


bool check_for_match(AdvPokemonResult res, AdvRngFilters target, uint16_t tid_xor_sid, uint8_t gender_threshold){
return (target.nature == Nature::Any || res.nature == target.nature)
&& (target.ability == Ability::Any || res.ability == target.ability)
&& (target.gender == Gender::Any || gender_from_gender_value(res.gender, gender_threshold) == target.gender)
&& (target.shiny == ShinyType::Any || shiny_type_from_pid(res.pid, tid_xor_sid) == target.shiny)
return (target.nature == AdvNature::Any || res.nature == target.nature)
&& (target.ability == AdvAbility::Any || res.ability == target.ability)
&& (target.gender == AdvGender::Any || gender_from_gender_value(res.gender, gender_threshold) == target.gender)
&& (target.shiny == AdvShinyType::Any || shiny_type_from_pid(res.pid, tid_xor_sid) == target.shiny)
&& (target.ivs.hp.low <= res.ivs.hp && target.ivs.hp.high >= res.ivs.hp)
&& (target.ivs.attack.low <= res.ivs.attack && target.ivs.attack.high >= res.ivs.attack)
&& (target.ivs.defense.low <= res.ivs.defense && target.ivs.defense.high >= res.ivs.defense)
Expand All @@ -148,7 +149,7 @@ AdvRng::AdvRng(uint16_t seed, AdvRngState state)
, state(state)
{}

AdvRng::AdvRng(uint16_t seed, uint64_t min_advances, RngMethod method)
AdvRng::AdvRng(uint16_t seed, uint64_t min_advances, AdvRngMethod method)
: seed(seed)
, state(rngstate_from_seed(seed, min_advances, method))
{}
Expand Down Expand Up @@ -177,21 +178,21 @@ void AdvRng::search_advance_range(
for (uint8_t m=0; m<3; m++){
set_state_advances(min_advances);

RngMethod method;
AdvRngMethod method;
switch (m){
case 1:
method = RngMethod::Method2;
method = AdvRngMethod::Method2;
break;
case 2:
method = RngMethod::Method4;
method = AdvRngMethod::Method4;
break;
case 0:
default:
method = RngMethod::Method1;
method = AdvRngMethod::Method1;
break;
}

if ((target.method != RngMethod::Any) && (target.method != method)){
if ((target.method != AdvRngMethod::Any) && (target.method != method)){
continue;
}

Expand Down Expand Up @@ -222,5 +223,148 @@ std::map<AdvRngState, AdvPokemonResult> AdvRng::search(
}


Pokemon::NatureAdjustments nature_to_adjustment(AdvNature nature){
NatureAdjustments ret;
ret.attack = NatureAdjustment::NEUTRAL;
ret.defense = NatureAdjustment::NEUTRAL;
ret.spatk = NatureAdjustment::NEUTRAL;
ret.spdef = NatureAdjustment::NEUTRAL;
ret.speed = NatureAdjustment::NEUTRAL;

switch (nature){
case AdvNature::Bashful:
case AdvNature::Docile:
case AdvNature::Hardy:
case AdvNature::Quirky:
case AdvNature::Serious:
return ret;

case AdvNature::Bold:
ret.attack = NatureAdjustment::NEGATIVE;
ret.defense = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Modest:
ret.attack = NatureAdjustment::NEGATIVE;
ret.spatk = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Calm:
ret.attack = NatureAdjustment::NEGATIVE;
ret.spdef = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Timid:
ret.attack = NatureAdjustment::NEGATIVE;
ret.speed = NatureAdjustment::POSITIVE;
return ret;

case AdvNature::Lonely:
ret.defense = NatureAdjustment::NEGATIVE;
ret.attack = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Mild:
ret.defense = NatureAdjustment::NEGATIVE;
ret.spatk = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Gentle:
ret.defense = NatureAdjustment::NEGATIVE;
ret.spdef = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Hasty:
ret.defense = NatureAdjustment::NEGATIVE;
ret.speed = NatureAdjustment::POSITIVE;
return ret;

case AdvNature::Adamant:
ret.spatk = NatureAdjustment::NEGATIVE;
ret.attack = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Impish:
ret.spatk = NatureAdjustment::NEGATIVE;
ret.defense = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Careful:
ret.spatk = NatureAdjustment::NEGATIVE;
ret.spdef = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Jolly:
ret.spatk = NatureAdjustment::NEGATIVE;
ret.speed = NatureAdjustment::POSITIVE;
return ret;

case AdvNature::Naughty:
ret.spdef = NatureAdjustment::NEGATIVE;
ret.attack = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Lax:
ret.spdef = NatureAdjustment::NEGATIVE;
ret.defense = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Rash:
ret.spdef = NatureAdjustment::NEGATIVE;
ret.spatk = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Naive:
ret.spdef = NatureAdjustment::NEGATIVE;
ret.speed = NatureAdjustment::POSITIVE;
return ret;

case AdvNature::Brave:
ret.speed = NatureAdjustment::NEGATIVE;
ret.attack = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Relaxed:
ret.speed = NatureAdjustment::NEGATIVE;
ret.defense = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Quiet:
ret.speed = NatureAdjustment::NEGATIVE;
ret.spatk = NatureAdjustment::POSITIVE;
return ret;
case AdvNature::Sassy:
ret.speed = NatureAdjustment::NEGATIVE;
ret.spdef = NatureAdjustment::POSITIVE;
return ret;

default:
throw InternalProgramError(nullptr, PA_CURRENT_FUNCTION, "Unknown Nature: " + std::to_string((int)nature));
}
}

void shrink_iv_range(IvRange& mutated_range, IvRange& fixed_range){
mutated_range.low = std::max(mutated_range.low, fixed_range.low);
mutated_range.high = std::min(mutated_range.high, fixed_range.high);
}

void shrink_iv_ranges(IvRanges& mutated_ranges, IvRanges& fixed_ranges){
shrink_iv_range(mutated_ranges.hp, fixed_ranges.hp);
shrink_iv_range(mutated_ranges.attack, fixed_ranges.attack);
shrink_iv_range(mutated_ranges.defense, fixed_ranges.defense);
shrink_iv_range(mutated_ranges.spatk, fixed_ranges.spatk);
shrink_iv_range(mutated_ranges.spdef, fixed_ranges.spdef);
shrink_iv_range(mutated_ranges.speed, fixed_ranges.speed);
}

AdvRngFilters observation_to_filter(AdvObservedPokemon& observation, BaseStats& basestats, AdvRngMethod method = AdvRngMethod::Method1){
IvRanges filter_iv_ranges = {{0,31},{0,31},{0,31},{0,31},{0,31},{0,31}};
for (int i=0; i<int(observation.level.size()); i++){
uint8_t lv = observation.level[i];
StatReads sts = observation.stats[i];
EVs ev = observation.evs[i];
NatureAdjustments nat = nature_to_adjustment(observation.nature);

IvRanges iv_ranges_at_level = calc_iv_ranges(basestats, lv, ev, sts, nat);
shrink_iv_ranges(filter_iv_ranges, iv_ranges_at_level);
}

return AdvRngFilters {
observation.gender,
observation.nature,
observation.ability,
filter_iv_ranges,
observation.shiny,
method
};
}


}
}
Loading