Skip to content

Comments

Fix pgoapi package repository hash#1117

Merged
elicwhite merged 1 commit intoPokemonGoF:masterfrom
rhysd:fix-pgoapi-version
Jul 27, 2016
Merged

Fix pgoapi package repository hash#1117
elicwhite merged 1 commit intoPokemonGoF:masterfrom
rhysd:fix-pgoapi-version

Conversation

@rhysd
Copy link
Contributor

@rhysd rhysd commented Jul 27, 2016

Short Description:

Fix 'pgoapi' package repository hash because latest one broke this bot. It seems that protobuf definition was updated. I think it is better that update pgoapi version with confirming manually.

Fixes:

  • Fixed pgoapi package's commit hash to the one with which at least I confirmed this bot worked well.

@eggins
Copy link
Contributor

eggins commented Jul 27, 2016

👍

Approved with PullApprove

@eggins
Copy link
Contributor

eggins commented Jul 27, 2016

There is a build error.
--editable=git+https://github.com/tejado/pgoapi.git@3787ffbe2e80ebce8a02d48eebceb9edf40179c1 is not the right format; it must have #egg=Package
The command "pip install -r requirements.txt" failed and exited with 1 during .

@rhysd rhysd force-pushed the fix-pgoapi-version branch from e884e5d to a397e3c Compare July 27, 2016 04:38
because latest one breaks this bot
@rhysd
Copy link
Contributor Author

rhysd commented Jul 27, 2016

@eggins

Ah, sorry, I forgot to add #egg=. I fixed in a397e3c

@solderzzc
Copy link
Contributor

solderzzc commented Jul 27, 2016

👍

Approved with PullApprove

@elicwhite elicwhite merged commit 9ea015e into PokemonGoF:master Jul 27, 2016
@rhysd rhysd deleted the fix-pgoapi-version branch July 27, 2016 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants