Items cleaner

[Surceis]

Short Description:
inventory cleaner and show more items at start

[elicwhite]

This looks much better, thanks for putting it up again.

I think this should be enabled behind a config flag.

[elicwhite]

The entry points to all workers needs to be called work. You can have your work function call something else though if you'd like.

[Surceis]

ok

[fredrik-hellmangroup]

If its a item cleaner function, it should defintly use the already existing item_filter config @TheSavior don't you agree?

[elicwhite]

Yes, if that exists, I definitely agree.

Looks like in SeenFortWorker we have:

id_filter = self.config.item_filter.get(str(item_id), 0)
                        if id_filter is not 0:
                            id_filter_keep = id_filter.get('keep',20)

We can probably use that logic, and by having a DropItemsWorker inside the event loop, we will be able to remove all logic about recycling items from the SeenFortWorker. That is very exciting.

[elicwhite]

👍

[fredrik-hellmangroup]

still some problems

Traceback (most recent call last):
File "D:\Pokemon stuff\PokemonGo-Bot\pokecli.py", line 40, in
from pokemongo_bot import PokemonGoBot
File "D:\Pokemon stuff\PokemonGo-Bot\pokemongo_bot__init__.py", line 17, in
from cell_workers import CatchVisiblePokemonWorker, PokemonCatchWorker, SeenFortWorker, MoveToFortWorker, InitialTransferWorker, EvolveAllWorker, DropItemsWorker
ImportError: cannot import name DropItemsWorker

[elicwhite]

👍

[ZgrK]

I started now and my inventory is this

but not started cleaning.

i'm waiting now until full

[douglascamata]

This GIGANTIC block of IFs makes me wanna cry. Why are you not using the item_filter? It's easy to add support to item names there, instead of IDs to make it more simple to the user. There is no way this PR is being merged with this craziness here. Check my PR for a very very simple DropItemWorker (I call it RecycleItemWorker, but whatever): #1156

[ZgrK]

After last update working

Still i'm testing

[ZgrK]

This branch has conflicts that must be resolved

[elicwhite]

@Zgrkaralar, the basics of this functionality were added in #1156. @Surceis said he'd look into adding these changes on top of that.