Allow google analytics collect bot event. by solderzzc · Pull Request #1289 · PokemonGoF/PokemonGo-Bot

solderzzc · 2016-07-27T23:49:47Z

Short Description:
Allow google analytics collect bot event.
Forbid personal information to be sent.

Forbid personal information to be sent.

elicwhite · 2016-07-27T23:54:37Z

This is a really scary and I imagine controversial thing to add. We are essentially gathering data on everyone using the bot and their usage. I think it would be valuable to do something like this so we can measure how the bot is being used, but we need to absolutely have a config flag that will let people disable it.

elicwhite · 2016-07-27T23:55:55Z

pokemongo_bot/central_ai/bot_event.py

+# -*- coding: utf-8 -*-
+from UniversalAnalytics import Tracker
+
+class BotEvent(object):


Should this be named Analytics?

douglascamata · 2016-07-27T23:56:54Z

@solderzzc there's one guy implementing the Event/Signal system for logging and web socket and he's almost done, let's w8 for this system to merge this PR. It will be much easier to integrate analytics as an EventHandler.

solderzzc · 2016-07-27T23:58:35Z

@douglascamata Sure, let's wait.
@TheSavior This is from https://github.com/analytics-pros/universal-analytics-python
To convert Google analytics JS version into HTTP post.

douglascamata · 2016-07-28T00:07:26Z

@solderzzc I agree with @TheSavior. We 100% need a config to disable data collection and if we set default option to collect data, we need to give users a BIG WARNING.

This reverts commit 90a17c0.

solderzzc · 2016-07-28T00:20:23Z

@douglascamata Sure, will work on it.

* adding random delay between pokemon capture & transfer. #774 * improved fix for #774 by adding click_action_delay function * wait time minimum & maximum are passed in from the config now * updated readme & contributors files * updated how action wait times are loaded from config * optimize docker usage (#1257) * update Dockerfile; install missed python-protobuf package; add CMD as a way of defining default arguments for the ENTRYPOINT * remove CMD command, default config parameter is also set in pokecli.py * Removed erroneous line in human_behavior and corrected bad merge resolution * updated configs & changed function name to action_delay

Big warning and wait for 2s to exit when set to enable this feature, the default value set to true.

… signal system merged.

jtdroste · 2016-07-28T01:08:47Z

pokecli.py

+        "--health_record",
+        help="Send anonymous bot event to GA for bot heath record, furthur ML will depend on it. Set \"health_record\":false if you need disable it.",
+        type=bool,
+        default=True


This should be defaulted to false. We should encourage people to opt-in, but it should never be the default for tracking.

heath > health

jtdroste · 2016-07-28T01:10:01Z

We should leave any collecting of data defaulted to off. Highly against defaulting this to true (aka on by default).

* seperate worker for transfering pokemons to professor pulled out initial transfer and transfer on catched pokemon to seperate worker * Fixed bug where config parameters wasnt checked * Initial_transfer renamed to release_pokemons Also updated the configuration argument function to release pokemon runs on tick method which is called after everyt small step the bot takes * added back exception which was missing * Default conf value and fixed typo * fixed typo for pokemon and updated config * added default value if its missing from conf NOTE: transfer conditions are set by "release" parameters in config, however we keep the highest CP of each pokemon, just to be sure we don't empty the bag. * Capital leter * missed to rename on some places Also enabled loggning to easier see why a certain pokemon may not be transfered to professor for candy * Log format update * moved runtime error to evolved_capture statement workaround if anyone should get it... fixing it in future

solderzzc · 2016-07-28T01:18:08Z

@jtdroste we have a big warning (in red) and two seconds waiting for exiting. Do you think that's reasonable for that?

Forbid personal information to be sent.

Big warning and wait for 2s to exit when set to enable this feature, the default value set to true.

… signal system merged.

into central_ai

solderzzc · 2016-07-28T01:32:45Z

Shouldn't use git rebase.

* Update README.md * Update README.md * Update README.md * Update ISSUE_TEMPLATE.md * Update README.md * Update README.md * direct pr to dev branch * Update README.md * Update PULL_REQUEST_TEMPLATE.md * Updated templates for master * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Added japanese pokemon name. (PokemonGoF#1116) * Update README.md * Update README.md * Update README.md * Update README.md * Update LICENSE * python 2.7 batch (PokemonGoF#1289) * added donation address * cleared master * Update map.js * Update map.js * Added back China coords transformation, (PokemonGoF#1423) (PokemonGoF#1424) which was deleted in some PR. * Change default display to no pokestops, no scan bubbles (PokemonGoF#1425) * Added new video guide to readme

…1289) * [Fix] issue PokemonGoF#622, statistics 2x Uncaught TypeError * Fix lint errors * Prevent OSK on Touch * Select Boxes prevent Virtual Keyboard Appearing on Touch Devices * remove unnecessary loop * basic mobile os detection

solderzzc added 2 commits July 27, 2016 16:48

Allow google analytics collect bot event.

c53fa6d

Forbid personal information to be sent.

Fixed module not include issue.

70e106f

elicwhite reviewed Jul 27, 2016
View reviewed changes

solderzzc added 2 commits July 27, 2016 17:08

Added GA in the README.me on dev branch first.

90a17c0

Revert "Added GA in the README.me on dev branch first."

6022dfb

This reverts commit 90a17c0.

johnsosoka and others added 5 commits July 28, 2016 10:33

Added config file to disable the heath_report(send status only to GA).

4ce2d61

Big warning and wait for 2s to exit when set to enable this feature, the default value set to true.

Remove the heath report inside pokemongo_bot/__init__.py, to wait the…

4fe72ae

… signal system merged.

Fixed typo in warning info.

7779811

Fixed typo in pokecli.py, remove the bot logout event in pokecli.

9982513

jtdroste reviewed Jul 28, 2016
View reviewed changes

fredrik-hellmangroup and others added 2 commits July 28, 2016 03:12

Fixed typo.

5dd1079

solderzzc added 8 commits July 27, 2016 18:27

Allow google analytics collect bot event.

ecdd96b

Forbid personal information to be sent.

Fixed module not include issue.

a5b5b45

Added config file to disable the heath_report(send status only to GA).

8131994

Big warning and wait for 2s to exit when set to enable this feature, the default value set to true.

Remove the heath report inside pokemongo_bot/__init__.py, to wait the…

806a6b6

… signal system merged.

Fixed typo in warning info.

1c8f501

Fixed typo in pokecli.py, remove the bot logout event in pokecli.

1c19849

Fixed typo.

264f009

Merge branch 'central_ai' of https://github.com/PokemonGoF/PokemonGo-Bot

02aeebd

into central_ai

solderzzc closed this Jul 28, 2016

solderzzc deleted the central_ai branch July 28, 2016 04:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Allow google analytics collect bot event.#1289

Allow google analytics collect bot event.#1289
solderzzc wants to merge 19 commits intodevfrom
central_ai

solderzzc commented Jul 27, 2016

Uh oh!

elicwhite commented Jul 27, 2016

Uh oh!

elicwhite Jul 27, 2016

Uh oh!

douglascamata commented Jul 27, 2016 •

edited

Loading

Uh oh!

solderzzc commented Jul 27, 2016

Uh oh!

douglascamata commented Jul 28, 2016 •

edited

Loading

Uh oh!

solderzzc commented Jul 28, 2016

Uh oh!

jtdroste Jul 28, 2016

Uh oh!

eggins Jul 28, 2016

Uh oh!

jtdroste commented Jul 28, 2016

Uh oh!

solderzzc commented Jul 28, 2016

Uh oh!

solderzzc commented Jul 28, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Comments

Conversation

solderzzc commented Jul 27, 2016

Uh oh!

elicwhite commented Jul 27, 2016

Uh oh!

elicwhite Jul 27, 2016

Choose a reason for hiding this comment

Uh oh!

douglascamata commented Jul 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solderzzc commented Jul 27, 2016

Uh oh!

douglascamata commented Jul 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

solderzzc commented Jul 28, 2016

Uh oh!

jtdroste Jul 28, 2016

Choose a reason for hiding this comment

Uh oh!

eggins Jul 28, 2016

Choose a reason for hiding this comment

Uh oh!

jtdroste commented Jul 28, 2016

Uh oh!

solderzzc commented Jul 28, 2016

Uh oh!

solderzzc commented Jul 28, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

douglascamata commented Jul 27, 2016 •

edited

Loading

douglascamata commented Jul 28, 2016 •

edited

Loading