Fixing evolve worker being skipped problem

[vicch]

Short Description:
EvolveAllWorker._should_run() logic was wrong, causing evolve worker not running at startup.

Fixes:

• Fixed EvolveAllWorker._should_run()

[vicch]

Should be able to solve #1335 , #1339 , #1456

[vicch]

There is a sleep(), but the last time I tried, it didn't seem to be working. No idea. This could be a whole other issue.
https://github.com/vicch/PokemonGo-Bot/blob/b13da71f428cf64904f0a6ee4d250387ee5b9063/pokemongo_bot/cell_workers/evolve_all_worker.py#L165

[douglascamata]

tests, please.

[stefansaraev]

works fine for me (EDIT: just testing evolve, not using lucky eggs here).

[thomaswelton]

Doesn't work. When set to use a luck egg the lucky egg is applied but the evloves are skipped.
I had to update the config so lucky egg was false then restart so it evolved.
Also there is no code that checks to see if a luck egg is already applied. If the bot is restarted and a luck egg is active then the evolves should run.

[thomaswelton]

That being said thanks for the pull request, it allowed me to evolve all the the 200 pidgeys I had collected previously for and allowed me to level up

[vicch]

@thomaswelton 200! That's pretty aggressive. You are welcome. Batch evolving is indeed vital for quick leveling. Hope this could get completely fixed soon.

[codybaldwin]

This will attempt to use a lucky egg every tick when the use_lucky_egg config is True

[vicch]

I suppose yes, if you set "use_lucky_egg": true and you actually have lucky eggs.

[codybaldwin]

so every 30 mins it will use a lucky egg. This doesn't seem ideal. Not only that, currently it will send the API request every second (technically tick) which is not good at all.

[vicch]

Already fixed and merged in #1541