Skip to content

Comments

Runtime Destination change though json.config file#1768

Closed
asaf400 wants to merge 6 commits intoPokemonGoF:devfrom
asaf400:dev
Closed

Runtime Destination change though json.config file#1768
asaf400 wants to merge 6 commits intoPokemonGoF:devfrom
asaf400:dev

Conversation

@asaf400
Copy link
Contributor

@asaf400 asaf400 commented Jul 30, 2016

Feature: Runtime Destination change though json.config file

New destination.json in config directory,
when it has a value, the bot will walk towards the destination (respects global speed)

Oprates like so:

Config File:

made get_pos_by_name a public function
Also made a PEP8 Fix for the Constants

@ewold
Copy link

ewold commented Jul 30, 2016

👍 Great, just what i needed. Hope this gets merged soon.

@elicwhite
Copy link
Contributor

The work that @douglascamata is to use websockets to support manual intervention of the bot, such as changing location like this. It will also support all sorts of other configuration and being able to be manipulated by a web ui. My guess is that is the right generic approach for this, but I'll let @douglascamata provide his thoughts.

@asaf400
Copy link
Contributor Author

asaf400 commented Jul 31, 2016

@TheSavior Yes, I am aware of that, Note that my code includes 2 workers.

1st worker trying to parse the config json file each tick,
If it detects a proper location, it sets Bot's global instance variable 'destination_location' to the Lat,Lng

2nd worker is listening for changes in the bot's variable 'destination_location', and walks there with the walking speed configured for the bot, and also, because the way workers are 'working' by an array order, it catches pokemon along the way so this can be used regardless of the 1st worker

So I can revise this PL, To include only the 2nd worker, so that @douglascamata can use it

@k4n30
Copy link
Contributor

k4n30 commented Aug 14, 2016

@asaf400 this merge is severly outdated. How do you want to proceed?

@elicwhite
Copy link
Contributor

@douglascamata How do we want to proceed with this based on the socket server?

@asaf400
Copy link
Contributor Author

asaf400 commented Aug 14, 2016

I Can rebase the changes to latest dev, and refactor the code to make it compatible with the new event log \ tasks which are the major changes made to the code since this PR.

@douglascamata Unfortunately I Didn't get you're messages about the socket server explanation in time, Slack Deleted those PMs.. So if you could quickly explain those here..

@solderzzc
Copy link
Contributor

Outdate, need close. Thanks for PR.

@solderzzc solderzzc closed this Aug 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants