Skip to content

fix #1766#1775

Closed
CapCap wants to merge 1 commit intoPokemonGoF:devfrom
CapCap:dev
Closed

fix #1766#1775
CapCap wants to merge 1 commit intoPokemonGoF:devfrom
CapCap:dev

Conversation

@CapCap
Copy link
Copy Markdown
Contributor

@CapCap CapCap commented Jul 30, 2016

Short Description:
dont use variables before you declare them

Fixes:

@Nihisil
Copy link
Copy Markdown
Contributor

Nihisil commented Jul 30, 2016

It is not fix, because pokemon_data not suppose to be empty.

So, something crashed inside def _check_inventory() and we need to fix it.

@Nihisil
Copy link
Copy Markdown
Contributor

Nihisil commented Jul 30, 2016

So, we need to find out why it crashed and fix it.

Also, as back up plan just in case we need to set pokemon_data = [] as you did.

@CapCap
Copy link
Copy Markdown
Contributor Author

CapCap commented Jul 30, 2016

yes, absolutely there is another problem: but there's no reason to try/catch if youre guaranteed to fail anyway

@Nihisil
Copy link
Copy Markdown
Contributor

Nihisil commented Jul 30, 2016

#1777 more global fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants