Simple lure attraction in move_to_fort worker#2068
Closed
z4ppy wants to merge 23 commits intoPokemonGoF:devfrom
z4ppy:dev
Closed
Simple lure attraction in move_to_fort worker#2068z4ppy wants to merge 23 commits intoPokemonGoF:devfrom z4ppy:dev
z4ppy wants to merge 23 commits intoPokemonGoF:devfrom
z4ppy:dev
Conversation
Disable by default
Member
|
@z4ppy please break down your lure attraction logic into many smaller methods. |
Member
|
@z4ppy need to solve merge conflicts with dev too, so I can merge. |
Contributor
Author
|
I did some smaller method and is better like that, ty :) |
Conflicts: CONTRIBUTORS.md
Contributor
Author
|
I don't know how launch unittest :( |
* add mock and nose to the dependencies * added unit tests for the api_wrapper * add testing to travis build * fixing path ? * pylint error fixed * adding myself to contributors * add test for the step_walker * add runtime error for big distances * change travis, nosetests should look for tests in all the folders * Getting rid of nose, rename some files, add 'timeout_decorator' to the requirements * update travis.yml * changed run_tests script from bash file to python file * revert file changes * skipping failing test * fix another test * some style/import improvment * revert SKIP_TIMEOUT * remove run_tests.py * move tests cases into main test folder * refactor some code api_wrapper_test * refactor and location parser * test is failing add a FIXME tag * location is now unicode friendly
* Warns if there aren't sufficient space left for loot. SpinFort will terminate silently, and users will not notice that SpinFort is skipping due to the lack of space. As a result, it sends out requests to Niantic even faster than before becuase tasks are looping faster and doing noops. More server busy (error 52) errors appear in the log without an explanation of what's actually going on. * improve readability of should_run for SpinFort and MoveToFort
* adapted to new commits * added config changed gitignore * added config * locked versions * typo * account for task management change * moved find_cluster to utils. follow_cluster now 1 task * added test for follow_cluster * added mock requirements * trying to get travis to build * trying to get travis to build * added search for lured cluster functionality * adapted tests * removed double specification
Member
|
@z4ppy more merge conflicts, sorry :/ |
* added secondary criteria so it doesn't jump from cluster to cluster when they're equally large * added secondary criteria so it doesn't jump from cluster to cluster when they're equally large * updated cluster example
Adding an Anyball item to the release config
Disable by default
Conflicts: CONTRIBUTORS.md
Member
|
@z4ppy your merge is a bit messy, showing modifications that doesn't belong to your PR... but I really want your feature. Do you mind opening another PR? |
Contributor
Author
|
I will redo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional lure attraction in move_to_fort